Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Considering renamed-only Files as Additions #328

Closed
alessio-signorini opened this issue Dec 28, 2018 · 0 comments
Closed

Stop Considering renamed-only Files as Additions #328

alessio-signorini opened this issue Dec 28, 2018 · 0 comments

Comments

@alessio-signorini
Copy link
Contributor

The current implementation of Git::Repository does not handle correctly file renames. These are the considered additions and create numerous issues when trying to submit Github PRs. A few of the linked issues I could find are:

  1. Pronto doesn't handle file renames well (Pronto doesn't handle file renames well #69)
  2. 422 - Validation Failed (422 - Validation Failed #149)
  3. pronto having issues with renamed files (pronto having issues with renamed files #218)
  4. Issue with renamed files and github_pull_request_review_formatter (Issue with renamed files and github_pull_request_review_formatter #259)
  5. Pronto is failing to post reviews to github pull request (Pronto is failing to post reviews to github pull request #284)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants