Correctly Handle renamed-only Files #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doomspork
previously requested changes
Dec 29, 2018
|
Should be all good now @doomspork, thanks for the review! |
… (e.g., unstaged, index, ...)
|
Awesome @alessio-signorini! I'm going to give the other @prontolabs/core folks a chance to look this over before I merge. |
|
@doomspork - did you hear back? :) |
|
@alessio-signorini concur with @doomspork - awesome job 😄 |
apiology
pushed a commit
to apiology/pronto
that referenced
this pull request
Dec 27, 2019
…named-only-files Correctly Handle renamed-only Files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of Pronto does not correctly consider renamed-only files which are considered new additions. This forces the runners to analyze the code and creates numerous issues when submitting PRs to Github. A summary of the issue and related issues can be found in #328.
This PR addresses the issue using
patches.find_similar!(:renames => true)so thatpatcheshave the correct type (i.e.,renamed) for those files. The analysis will be slightly slower but it should not be a problem.