Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when there is no Github PR #49

Closed
Linuus opened this issue Nov 19, 2014 · 1 comment
Closed

Crash when there is no Github PR #49

Linuus opened this issue Nov 19, 2014 · 1 comment
Assignees

Comments

@Linuus
Copy link

Linuus commented Nov 19, 2014

If I run pronto on a branch with the github_pr formatter it crashes if there is no PR.
octokit-3.5.2/lib/octokit/response/raise_error.rb:16:inon_complete': POST https://api.github.com/repos/Linuus/foobar/pulls/comments: 404 - Not Found // See: https://developer.github.com/v3 (Octokit::NotFound)`

Maybe it should just emit a more friendly message instead if the PR ID detection fails to find a PR.

@mmozuras mmozuras self-assigned this Nov 19, 2014
@mmozuras
Copy link
Member

@Linuus thanks for suggestion! This will be part of next release 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants