Colorize text formatter #134
Conversation
|
|
||
| def rainbow | ||
| @rainbow ||= Rainbow.new.tap do |rainbow| | ||
| rainbow.enabled = config.text_formatter_colors && $stdout.tty? |
There was a problem hiding this comment.
Much more terse, with improved clarity, than the equivalent rubocop cop code. Nice job!
|
@tscheffe Thank you for your thorough code review! Please check my replies and fixup commit. I hope you will like the end result better. :) |
|
Everything is looking good to me! Works great! Waiting on review from @mmozuras then right? |
|
Thanks, Trent! @mmozuras |
|
@nbekirov looks good 👍 |
|
@mmozuras Indeed, the config toggle is not needed per se - I'll remove it. |
nbekirov
force-pushed
the
colorize-text-formatter
branch
from
3409ff8 to
e6bd124
Compare
- Add Rainbow dependency
- Add Colorizable mixin
- Apply Colorizable to TextFormatter
- location
- level
- Add/Update specs
nbekirov
force-pushed
the
colorize-text-formatter
branch
from
e6bd124 to
1a4548b
Compare
|
@mmozuras I've removed the configuration, rebased, and squashed! Please let me know what do you think. 😃 |
|
@nbekirov amazing, thanks 👏 😄 |
This PR colorizes the text formatter to improve terminal readability when used locally.
Before
After
Configuration
The new feature is controlled via
text_formatter:colorsproperty in.pronto.yml. This is also reflected in theREADME.md. By default it's disabled.This feature is always disabled (configuration is ignored) when not in TTY to enable file I/O redirection,
grep, etc.N.B. I've had some hard time trying to enable it by default as there seems to be some issues with overriding truthy
ConfigFile::EMPTYvalues via.pronto.yml/ENVsettings. I'll investigate further and report back.P.S. I've left the proposed
--coloredoption out as it would require a bit of a bigger refactoring to centralize the configuration and its modification. CurrentlyTEXT_FORMATTER_COLORS=true pronto runwill be available as an alternative.New dependencies
I've used Rainbow as suggested in #129.
Colorizable mixin
This is a reusable module intended to be used by any formatter that may need colorization. Its implementation is inspired by the one seen in Rubocop.
Colors and styles
The colors I've used are inspired by Rubocop as I find them to be quite nice and recognizable.
Resolves #129