This repository has been archived by the owner on Jan 19, 2024. It is now read-only.
Event distributor part2 #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydiemho
force-pushed
the
eventDistributorPart2
branch
from
2ce75fb to
8a3fcb3
Compare
mydiemho
force-pushed
the
eventDistributorPart2
branch
from
8a3fcb3 to
1ed896b
Compare
|
LGTM |
|
Since @mydiemho is out I will take care of this. If you want another round of reviews after I fix the above items let me know. Otherwise I'll create a new pull (for posterity), and push it into master shortly after. |
|
Unless we have good reason to do otherwise, we should continue to merge only fully reviewed code. |
|
To be superceded by pull request #53 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add support for generating static event taps based on configuration.