Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ConfigurableAggregateTranslator? #43

Closed
codeliner opened this issue Jan 1, 2017 · 1 comment
Closed

Remove ConfigurableAggregateTranslator? #43

codeliner opened this issue Jan 1, 2017 · 1 comment
Milestone

Comments

@codeliner
Copy link
Member

codeliner commented Jan 1, 2017

Coming up prooph/event-store v7 no longer contains Aggregate related classes. They are all moved to prooph/event-sourcing. Now we have two AggregateTranslator implementations in one package.
Originally the ConfigurableAggregateTranslator was meant to be a default implementation if one don't want to use prooph/event-sourcing.
With the new structure the ConfigurableAggregateTranslator is no longer needed. prooph/event-sourcing uses the decorator pattern and has its own AggregateTranslator in place.

W could create a gist of the ConfigurableAggregateTranslator instead and link it in the docs if one don't like the decorator approach.

@prolic
Copy link
Member

prolic commented Jan 3, 2017

👍 for removing

mentioning it in the docs that this has been removed comletely is necessary. (see my docs-pr #41).

creating a gist is optional I think. You can always implement the translator-interface yourself.

prolic added a commit that referenced this issue Jan 4, 2017
@prolic prolic added this to the 5.0 Release milestone Jan 4, 2017
@prolic prolic closed this as completed Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants