Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JsonSerializable mock #44

Closed
prolic opened this issue Jan 3, 2017 · 0 comments
Closed

Remove JsonSerializable mock #44

prolic opened this issue Jan 3, 2017 · 0 comments
Assignees
@sandrokeil
Labels
enhancement
Milestone
5.0 Release

Comments

@prolic
Copy link
Member

prolic commented Jan 3, 2017

see: 818fca6

@sandrokeil wanna take over the job and revert that pr?
@prolic prolic added this to the 5.0 Release milestone Jan 3, 2017
sandrokeil added a commit to sandrokeil/event-sourcing that referenced this issue Jan 3, 2017
@sandrokeil
Remove JsonSerializable Mock objects for User and UserNameChanged (close
2cd0d79 
 prooph#44)

- there were introduced to test \JsonSerializable for snapshots, but it doesn't work because we can not create other deeper objects
@prolic prolic closed this as completed Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandrokeil sandrokeil

Labels
enhancement
Projects
None yet
Milestone
5.0 Release
Development

No branches or pull requests
2 participants
@prolic @sandrokeil