Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update event sourcing for new interface #34

Merged
merged 2 commits into from
Nov 8, 2016
Merged

Conversation

prolic
Copy link
Member

@prolic prolic commented Nov 7, 2016

No description provided.

$aggregateId
);
$metadataMatcher = $metadataMatcher->withMetadataMatch(
'_version',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it requires more work, but it would be nice if we rename _version to _aggregate_version to make the concept and difference between domain event version and event no in the streams explicit. What do you think @prolic ?

@prolic
Copy link
Member Author

prolic commented Nov 7, 2016

Ok no problem. Will update those 100 repos tomorrow :-)

Am 08.11.2016 01:24 schrieb "Alexander Miertsch" [email protected]:

@codeliner requested changes on this pull request.

In src/Aggregate/AggregateRepository.php
#34 (review)
:

  •            $snapshot->lastVersion() + 1
    
  •        );
    
  •    } else {
    
  •        $metadataMatcher = new MetadataMatcher();
    
  •        $metadataMatcher = $metadataMatcher->withMetadataMatch(
    
  •            '_aggregate_type',
    
  •            Operator::EQUALS(),
    
  •            $this->aggregateType->toString()
    
  •        );
    
  •        $metadataMatcher = $metadataMatcher->withMetadataMatch(
    
  •            '_aggregate_id',
    
  •            Operator::EQUALS(),
    
  •            $aggregateId
    
  •        );
    
  •        $metadataMatcher = $metadataMatcher->withMetadataMatch(
    
  •            '_version',
    

I know it requires more work, but it would be nice if we rename _version
to _aggregate_version to make the concept and difference between domain
event version and event no in the streams explicit. What do you think
@prolic https://github.com/prolic ?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#34 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAYEvE1xwPfb11pqL1J5oC2-r4z0PusAks5q717UgaJpZM4KrSKk
.

@prolic prolic merged commit 50c706d into develop Nov 8, 2016
@prolic prolic deleted the new_interfaces_update branch November 8, 2016 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants