Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds early return if no pending event is present #47

Merged
merged 1 commit into from
Jan 4, 2017
Merged

adds early return if no pending event is present #47

merged 1 commit into from
Jan 4, 2017

Conversation

oqq
Copy link
Member

@oqq oqq commented Jan 4, 2017

closes #42

@oqq
Copy link
Member Author

oqq commented Jan 4, 2017

@prolic i would using beta hashes to prevent this failing tests.

"prooph/common" : "^4.0@beta",
"prooph/event-store" : "^7.0@beta

Any reason against that?

@prolic
Copy link
Member

prolic commented Jan 4, 2017

yes, it's fixed here: #46

@prolic
Copy link
Member

prolic commented Jan 4, 2017

Looks good, let's merge #46 first, than this should turn green, when we restart travis.

@prolic prolic merged commit ecc932d into prooph:develop Jan 4, 2017
@oqq oqq deleted the issue-42 branch January 4, 2017 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oqq @prolic