Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs #60

Merged
merged 5 commits into from
Mar 26, 2017
Merged

Docs #60

merged 5 commits into from
Mar 26, 2017

Conversation

prolic
Copy link
Member

@prolic prolic commented Mar 25, 2017

resolves #59

@prolic prolic added this to the 5.0 Release milestone Mar 25, 2017
@prolic prolic requested a review from codeliner March 25, 2017 08:07
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.908% when pulling 2a21836 on docs into 90395f0 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.908% when pulling 26ce160 on docs into 90395f0 on develop.

basz
basz approved these changes Mar 25, 2017
View reviewed changes
docs/migration.md Outdated
@@ -34,8 +34,8 @@ then you can implement the `Prooph\EventSourcing\Aggregate\AggregateTranslator`

## Snapshot Store

The snapshot store is now a simple interface, see `Prooph\EventSourcing\Snapshot\SnapshotStore`. The adapters are all removed
and replaced by different snapshot store implementation, f.e. `Prooph\EventSourcing\Snapshot\InMemorySnapshotStore`.
The snapshot store is now a simple interface, see `Prooph\SnapshotStore\SnapshotStore`. The adapters are all removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have all been removed ... and replaced with ...

docs/repositories.md Outdated
@@ -112,7 +60,6 @@ in a `user_stream`.

The repository can also be configured to create a new stream for each new aggregate instance. You need to turn the last
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'' need to set the last constructor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.908% when pulling fddc563 on docs into 90395f0 on develop.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.908% when pulling 7c9f037 on docs into 90395f0 on develop.

@codeliner
Copy link
Member

Great work

@codeliner codeliner merged commit 66079a8 into develop Mar 26, 2017
@prolic prolic deleted the docs branch March 26, 2017 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basz basz basz approved these changes

@codeliner codeliner codeliner approved these changes

Assignees

@codeliner codeliner

Labels
documentation
Projects
None yet
Milestone
5.0 Release
Development

Successfully merging this pull request may close these issues.
4 participants
@prolic @coveralls @codeliner @basz