Allow to add a custom event store to AggregateRepository #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolic
reviewed
Apr 30, 2018
|
@prolic Yes that's it, the default one like in documentation or example and a custom one. By default it will retrieve the |
prolic
requested changes
Apr 30, 2018
| $eventStore = $container->get(EventStore::class); | ||
| $eventStoreClass = $config['event_store_class'] ?? EventStore::class; | ||
|
|
||
| $eventStore = $container->get($eventStoreClass); |
There was a problem hiding this comment.
change to: $eventStore = $container->get($config['event_store']);
There was a problem hiding this comment.
Also, implement ProvidesDefaultConfig and add EventStore::class as default option to event_store.
|
|
||
| $eventStore = $container->get($eventStoreClass); | ||
|
|
||
| if (! $eventStore instanceof EventStore) { |
There was a problem hiding this comment.
I don't think we need this, as the aggregate repository already has a typehint for this, so we'll catch that exception already.
| @@ -81,7 +81,13 @@ public function __invoke(ContainerInterface $container): AggregateRepository | |||
| throw ConfigurationException::configurationError(sprintf('Repository class %s must be a sub class of %s', $repositoryClass, AggregateRepository::class)); | |||
| } | |||
|
|
|||
| $eventStore = $container->get(EventStore::class); | |||
| $eventStoreClass = $config['event_store_class'] ?? EventStore::class; | |||
|
LGTM. 👍 @Orkin Please run |
prolic
approved these changes
Apr 30, 2018
|
@prolic it is ok for you like this ? |
prolic
approved these changes
Apr 30, 2018
|
Thanks @Orkin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can be really useful when the
one_stream_per_aggregateconfig is set to true. Real event stream table is automatically create on save and for one of my use case I have a different format for aggregate_id (concatenation of 2 uuid separate by_) so the column length will become 73 instead of 36. I have my own stream strategy but only for one stream so when I configure my aggregate_repository I need to inject my custom event store