-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say, very clean! Please view my comments as suggestions not criticism. These are complex concepts and haven't fully internalised every bit of them. They seem to be interconnected (eg. snapshots are projections of serialised AR's but the state of a snapshot projector is actually the last event processed). The simplicity of creating streams in combination of the emit method seems very powerful to me, but I can't explain why yet...
anyway just my thoughts here
|
||
## DB migrations | ||
|
||
If you are using v6 with MySQL (using doctrine adpater) and you want to switch to v7 with MySQL (using pdo-event-store), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this only true for mysql?
docs/migration.md
Outdated
update your source code to make this change. You need to write a migration script, take the database offline, | ||
perform the migration and go back online. | ||
|
||
As this is a very tough job, we don't provide any migration script currently and for some applications a downtime is not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you can't go down you can't upgrade... ok noted... but if i can go down, what would I need to do? loop through table with events, create new stream, read old and persist new events. more..?
# Projections | ||
|
||
New in v7 are queries and projectons. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this document I've come to realise that a query is the actually the same thing as a projection but without persistence of state.... Usually one might think of a query as a representation of (pre) calculated state. I thought for example that queries are a way to retrieve persisted projection state.
I think it would be good to add a small section here explaining this subtlety. Looping over a (sub)set of events (a stream) and updating a running state while you do so. Projections stores state, query executed each time.
thanks for your feedback @basz - I added some more lines to the docs. |
@mablae @oqq @bweston92 please leave some feedback, if the docs help you out to understand what's going on here, tell me it needs improvements, and so on. |
@oqq @codeliner @basz small interface change done here. I added the locktimeout option to the interface, it will be removed from the pdo-event-store. |
Very nice and clean explanation of the migration steps and the new projection features. Well done! If no further updates are planed it can be merged. |
thanks for the review @codeliner and @basz |
resolves #191