Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should resetProjection always be called? #38

Closed
codeliner opened this issue Jan 12, 2017 · 2 comments
Closed

Should resetProjection always be called? #38

codeliner opened this issue Jan 12, 2017 · 2 comments

Comments

@codeliner
Copy link
Member

I'm wondering if this line should be moved above the if block so that $this->resetProjection() gets called even if the initCallback returns a state array?
@prolic
Copy link
Member

prolic commented Jan 13, 2017

No, it doesn't matter if a callback is provided or not. If you call reset() on a read model projection, the read model needs to be reset.

codeliner added a commit that referenced this issue Jan 13, 2017
@codeliner
Always call reset projection
b9dc349 
Fixes #38
@codeliner codeliner mentioned this issue Jan 13, 2017
Merged
@prolic
Copy link
Member

prolic commented Jan 14, 2017

Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prolic @codeliner