Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for stopping projections and queries, fix small bug #11

Merged
merged 3 commits into from
Nov 19, 2016

Conversation

prolic
Copy link
Member

@prolic prolic commented Nov 18, 2016

see: #10

@prolic prolic added the bug label Nov 18, 2016
@prolic
Copy link
Member Author

prolic commented Nov 18, 2016

/cc @codeliner

Copy link
Member

@basz basz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

})
->run();

$this->assertEquals(10, $projection->getState()['count']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no test on the model?

})
->run();

$this->assertEquals(10, $projection->getState()['count']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

idem?

@prolic
Copy link
Member Author

prolic commented Nov 18, 2016

@basz I updated the read model projection tests

@prolic prolic merged commit aa5249a into master Nov 19, 2016
@prolic prolic deleted the stop_tests branch November 19, 2016 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants