Add message to ConcurrencyException #163
Conversation
|
|
||
| use Prooph\EventStore\Exception\ConcurrencyException; | ||
|
|
||
| class ConcurrencyExceptionFactory |
There was a problem hiding this comment.
This can be a named constructor on the concurrency exception itself, no need for an additional class
There was a problem hiding this comment.
It can't. ConcurrencyException is in another package which should not be aware of something like PDO.
The only way I could use a named constructor here would be to extend that exception. I slightly prefer this solution though.
There was a problem hiding this comment.
Oh you're right. I'm okay with having a factory then.
|
About action event emitter, why not set the exception itself instead if bool true? Same could be for stream not found |
|
@prolic Oh I somehow thought the event parameters are limited to just scalars and maybe arrays of scalars. If that's not the case then just setting the exception to the parameter is of course far better since it will preserve the original call stack. |
Closes #161.
I don't think we can easily detect if the problem was an aggregate ID or an event ID (not without an additional select to check for duplicates). However the information seems to be in PDO's ErrorInfo so I'd like to simply pass it along in the exception message.
This will of course require another PR for
ActionEventEmitterEventStoreto pass the message along here instead of the boolean.I'll send that PR later. Unless of course you're against this solution.