Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a second optional MetadataMatcher parameter for fromStream methods #177

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Conversation

fjogeleit
Copy link
Contributor

@fjogeleit fjogeleit commented Nov 1, 2018

Implementation a second optional parameter for fromStream Methods. So its possible to filter Streams for Projections, Queries and so on. As example is it possible to filter for an AggregationID to create Projections for a single Aggregate with the SingleStream- or SimpleStreamStrategy

@fjogeleit fjogeleit changed the title [WIP] Implement new fromStreamWithMetadataMatcher Method for PdoEventStorQuery [WIP] Implement new fromStreamWithMetadataMatcher Method for PdoEventStoreQuery Nov 1, 2018
@coveralls
Copy link

coveralls commented Nov 1, 2018

Coverage Status

Coverage increased (+0.02%) to 89.368% when pulling 75bd7f6 on fjogeleit:master into 53bbbac on prooph:master.

@fjogeleit fjogeleit changed the title [WIP] Implement new fromStreamWithMetadataMatcher Method for PdoEventStoreQuery Implement a second optional MetadataMatcher parameter for fromStream methods Nov 2, 2018
@prolic prolic merged commit 305ee14 into prooph:master Nov 3, 2018
@sandrokeil
Copy link
Member

@prolic This should also be part of the appropriate interface like Query or?

@prolic
Copy link
Member

prolic commented Nov 15, 2018

@sandrokeil We can't change the interface, because that would be a BC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants