Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for starting a Projector with stopping state, looses stream position state #180

Merged

Conversation

basz
Copy link
Member

@basz basz commented Nov 4, 2018

No description provided.

@basz
Copy link
Member Author

basz commented Nov 4, 2018

issue #179

@basz
Copy link
Member Author

basz commented Nov 5, 2018

Looks like this fixes the immediate issue.

@coveralls
Copy link

coveralls commented Nov 5, 2018

Coverage Status

Coverage increased (+0.01%) to 89.38% when pulling ff92356 on basz:fix/projector-looses-stream-positions-state into b6f1716 on prooph:master.

@basz basz mentioned this pull request Nov 5, 2018
@basz basz changed the title failing tests Fix for starting a Projector with stopping state, looses stream position state Nov 5, 2018
@basz
Copy link
Member Author

basz commented Nov 7, 2018

@prolic could I nudge you to merge/release this one? It is biting me... :-/

Copy link
Member

@prolic prolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReadModelProjector needs this change as well

@prolic prolic added the bug label Nov 10, 2018
@prolic prolic self-assigned this Nov 10, 2018
@prolic prolic merged commit df6fb9d into prooph:master Nov 10, 2018
@basz basz deleted the fix/projector-looses-stream-positions-state branch May 13, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants