Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds missing phpunit group annotations to container test classes #33

Merged
merged 2 commits into from
Jan 10, 2017
Merged

adds missing phpunit group annotations to container test classes #33

merged 2 commits into from
Jan 10, 2017

Conversation

oqq
Copy link
Member

@oqq oqq commented Jan 10, 2017 •
edited
Loading

UnitTests would fail with messages like

"Extension "pdo_pgsql" is not loaded"

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.5%) to 95.747% when pulling ca4b8da on oqq:bugfix/test_groups into e8bb194 on prooph:projections_update.

@prolic
Copy link
Member

prolic commented Jan 10, 2017

Can you also put the factories to the excluded files for coverage in the depending phpunit files?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 99.216% when pulling b4a513a on oqq:bugfix/test_groups into e8bb194 on prooph:projections_update.

@prolic prolic merged commit 6371114 into prooph:projections_update Jan 10, 2017
@oqq oqq deleted the bugfix/test_groups branch January 10, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oqq @coveralls @prolic