use prepared load statements #44
Conversation
| @@ -78,7 +76,6 @@ public function __construct( | |||
| PDO $connection, | |||
| PDOStatement $statement, | |||
| MessageFactory $messageFactory, | |||
| array $sql, | |||
| ?int $batchSize, | |||
| int $fromNumber, | |||
| int $count, | |||
There was a problem hiding this comment.
is bool forward still needed then?
There was a problem hiding this comment.
| { | ||
| $limit = $this->count < ($this->batchSize * ($this->batchPosition + 1)) | ||
| ? $this->count - ($this->batchSize * $this->batchPosition) | ||
| : $this->batchSize; | ||
|
|
||
| if ($this->forward) { |
| $sql['where'][] = "metadata ->> '$field' $operator $value"; | ||
| } else { | ||
| $sql['where'][] = "metadata ->> '$field' $operator '$value'"; | ||
| $where[] = "metadata->'$field' $operator '".var_export($value, true)."'"; |
There was a problem hiding this comment.
metadata ->> instead of metadata ->
see: https://www.postgresql.org/docs/9.3/static/functions-json.html
-> means: Get JSON object field
->> means: Get JSON object field as text
There was a problem hiding this comment.
I am not sure about that, but mysql declares
->> as shortcut for JSON_UNQUOTE(JSON_EXTRACT()), and
-> as shortcut for JSON_EXTRACT()
So ->> is always an extra step. With -> all tests passes. Maybe Postgre is fine with. Should we add an extra step?
| $value = var_export($value, true); | ||
| } elseif (is_string($value)) { | ||
| $value = $this->connection->quote($value); | ||
| $where[] = "metadata->\"$.$field\" $operator ".var_export($value, true); |
There was a problem hiding this comment.
I think this should be metadata->> to unquote.
There was a problem hiding this comment.
Than it would also match 'true' === true. Right?
|
great work! thx! 👍 |
Currently the queries in aggregate load methods from event stores builds queries and recreate this for batch requests.
This PR changes this behavior and implements prepared statements. The PdoStreamIterator has only to change the values for
fromNumberandlimitwithout have to know how to queries should be builded.