Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve event store indexes #66

Merged
merged 6 commits into from
Mar 12, 2017
Merged

Improve event store indexes #66

merged 6 commits into from
Mar 12, 2017

Conversation

prolic
Copy link
Member

@prolic prolic commented Mar 11, 2017

resolves #43

/cc @basz @oqq

@prolic prolic added the bug label Mar 11, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.096% when pulling 6c9fee8 on indexes into 1684868 on master.

Copy link
Member

@oqq oqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts here: #43 (comment)

@prolic
Copy link
Member Author

prolic commented Mar 12, 2017

See also discussion here: #43 - I added some additional comments there.

@prolic
Copy link
Member Author

prolic commented Mar 12, 2017

PostgresSimpleStreamStrategy is updated to have another indexing including no - same optimization was not successful for MySQL at the moment.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.098% when pulling 0d83f0a on indexes into 1684868 on master.

@prolic
Copy link
Member Author

prolic commented Mar 12, 2017

@oqq that should do the trick

@codeliner please review as well - I added a new interface - please check naming and namespace location.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.098% when pulling da1ebfa on indexes into 1684868 on master.

@prolic
Copy link
Member Author

prolic commented Mar 12, 2017

need to fix some tests, wait a minute ....

@prolic
Copy link
Member Author

prolic commented Mar 12, 2017

ok ready @codeliner @oqq @basz

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.098% when pulling 0128e49 on indexes into 1684868 on master.

Copy link
Member

@codeliner codeliner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I 'm not a RDBMS expert. @oqq and @basz please also take a look

@prolic prolic merged commit 0062b58 into master Mar 12, 2017
@prolic prolic deleted the indexes branch March 12, 2017 14:57
@basz
Copy link
Member

basz commented Mar 12, 2017

Looks like a dramatic improvement. Performance is stable at about ~90 commands per seconds (yielding ~3 events each)

    "prooph/pdo-event-store":                           "dev-master as 1.0.0-beta4",

First 180 seconds 92.5 commands/s
Last 180 seconds 88.6 commands/s
done in ~6 minutes

    "prooph/pdo-event-store":                           "dev-master#16848680e2f963fbaf2cdf015c6b788156fe8385 as 1.0.0-beta4",

First 60 seconds 43.6 commands/s
First 180 seconds 38.3 commands/s
Last 180 seconds 9.4 commands/s
done in ~35 minutes

So, thanks for the great work on this @oqq @prolic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve event store indexes
5 participants