Support message property filters + new operators #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolic
changed the title
codeliner
approved these changes
May 23, 2017
basz
approved these changes
May 23, 2017
src/MySqlEventStore.php
Outdated
| } | ||
|
|
||
| $where[] = "metadata->\"$.$field\" $operator $parameter"; | ||
| $values[$parameter] = $value; | ||
| if (FieldType::METADATA()->is($fieldType)) { |
There was a problem hiding this comment.
Why not;
Operator->is(...) for eadability?
There was a problem hiding this comment.
It's field type, not operator :)
| $parameter = ':metadata_'.$key; | ||
| $parameters = []; | ||
|
|
||
| if (is_array($value)) { |
There was a problem hiding this comment.
Make array if not array, then loop through?
There was a problem hiding this comment.
ah not ok, it's different behaviour, see the code below
src/PostgresEventStore.php
Outdated
|
|
||
| $operatorStringEnd = ''; | ||
|
|
||
| if (Operator::REGEX()->is($operator)) { |
There was a problem hiding this comment.
problem is auto complete missing then
There was a problem hiding this comment.
/** @var FQCN $operator */? you against that?
codeliner
approved these changes
May 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see prooph/event-store#286
see prooph/event-store#284