Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MariaDB support #83

Merged
merged 15 commits into from
Jun 18, 2017
Merged

Add MariaDB support #83

merged 15 commits into from
Jun 18, 2017

Conversation

prolic
Copy link
Member

@prolic prolic commented May 31, 2017

resolves #72

@coveralls
Copy link

Coverage Status

Coverage decreased (-7.6%) to 84.263% when pulling 0da90d4 on mariadb into d55896f on master.

@prolic
Copy link
Member Author

prolic commented May 31, 2017

@codeliner @sandrokeil any help is appreciated! I cannot get mariadb to run

@prolic
Copy link
Member Author

prolic commented May 31, 2017

SELECT VERSION() give me 5.6.33-0ubuntu0.14.04.1 which indicates mysql instead of mariadb is running.

@prolic
Copy link
Member Author

prolic commented May 31, 2017

Ok this problem only exists with MariaDB 10.2.4, 10.0 and 10.3 seem to work, I continue tomorrow.

@prolic
Copy link
Member Author

prolic commented May 31, 2017

I just tested a few things, including adding a sleep 10 to the build, but sometimes I get mariadb up and running and sometimes I get mysql up. I don't know why.

@prolic
Copy link
Member Author

prolic commented Jun 2, 2017

Ok MariaDB setup on travis works now, I try to fix the rest of the tests tomorrow.

@codeliner
Copy link
Member

great @prolic , sorry that I could not hep out

@prolic prolic changed the title [WIP] Add MariaDB support [Add MariaDB support Jun 4, 2017
@prolic prolic changed the title [Add MariaDB support Add MariaDB support Jun 4, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-36.4%) to 55.474% when pulling 3359d69 on mariadb into d55896f on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 91.908% when pulling 644e859 on mariadb into d55896f on master.

@prolic prolic merged commit b615a0f into master Jun 18, 2017
@prolic prolic deleted the mariadb branch June 18, 2017 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reconsider adding support for MariaDB
3 participants