-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move templates into own root level. #1848
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1848 +/- ##
============================================
+ Coverage 87.75% 87.84% +0.09%
- Complexity 7761 7771 +10
============================================
Files 282 226 -56
Lines 21291 21048 -243
============================================
- Hits 18684 18490 -194
+ Misses 2607 2558 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@mringler @nederdirk |
I will merge now. |
Solves #1634
The idea:
Template paths are by convention in
Any extensions should follow the same convention or pass their custom path to renderTemplate()
BC Impact:
If needed, we could add a shim to lookup also in old "folder" - if not found in new primary location.
This would mitigate the impact.