Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced deprecated find_pylintrc by find_default_config_files #643

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

perestoronin
Copy link
Contributor

Replaced deprecated find_pylintrc by find_default_config_files

PS. inpired by https://github.com/spyder-ide/spyder/pull/21470/files

Description

patch error cannot import name 'find_pylintrc' from 'pylint.config' for latest pylint 3.0.2

Related Issue

pylint-dev/pylint#9105

Motivation and Context

To work prospector with last pylint 3.0.2

How Has This Been Tested?

run prospector --help with latest pylint 3.0.2 without error about

File "/usr/lib/python3.11/site-packages/prospector/tools/pylint/__init__.py", line 8, in <module>
    from pylint.config import find_pylintrc
ImportError: cannot import name 'find_pylintrc' from 'pylint.config' (/usr/lib/python3.11/site-packages/pylint/config/__init__.py)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed.

Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fix typo
@nfelt14
Copy link

nfelt14 commented Sep 19, 2024

@Pierre-Sassoulas, what will it take to get this merged and released?

@carlio
Copy link
Member

carlio commented Sep 19, 2024

It will take me pulling my finger out my arse.

Sorry for being absent. I'll do my best to get on this on Monday.

@nfelt14
Copy link

nfelt14 commented Sep 23, 2024

It will take me pulling my finger out my arse.

Sorry for being absent. I'll do my best to get on this on Monday.

Just following up on this, any updates?

@nfelt14
Copy link

nfelt14 commented Oct 3, 2024

It will take me pulling my finger out my arse.

Sorry for being absent. I'll do my best to get on this on Monday.

@carlio, Any new updates?

@sbrunner
Copy link
Member

sbrunner commented Oct 3, 2024

Should we fork the project?

@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.11.0 milestone Oct 3, 2024
@Pierre-Sassoulas Pierre-Sassoulas merged commit e614c51 into prospector-dev:master Oct 3, 2024
5 checks passed
@carlio
Copy link
Member

carlio commented Oct 4, 2024

Sorry once again for being absent, real life got in the way and to be honest enthusiasm has died a bit.

@sbrunner rather than fork, I'd suggest adding you and any others to the project as maintainers, if you would like. I'll still try to take part in maintenance.

I'm also happy to move it out of this GitHub org, along with dependencies which are tied to it (like requirements-detector).

@sbrunner
Copy link
Member

sbrunner commented Oct 4, 2024

@carlio Yes it's a good idea Relay like Prospector and us it in many projects :-)

Thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants