Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the types, test it using Mypy #687

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Add the types, test it using Mypy #687

merged 2 commits into from
Oct 22, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Oct 21, 2024 •
edited
Loading

Description

I do the minimal code change, the biggest is removing the ProfileValidationTool hack in prospector/tools/init.py.

Motivation and Context

  • Have an easier to understand code
  • Prevent, against some regression

@sbrunner sbrunner force-pushed the mypy branch 10 times, most recently from ef5f30b to 54e6de8 Compare October 21, 2024 19:16
@sbrunner sbrunner marked this pull request as ready for review October 21, 2024 19:22
@sbrunner sbrunner mentioned this pull request Oct 21, 2024
Closed
@sbrunner sbrunner requested review from carlio and Pierre-Sassoulas and removed request for carlio October 21, 2024 19:36
Pierre-Sassoulas
Pierre-Sassoulas approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot to review here, great work, I didn't see anything dodgy but then I took only 15mn for the review. We can probably iterate on it later if there's small mistakes.

@sbrunner sbrunner merged commit 4759399 into master Oct 22, 2024
5 checks passed
@sbrunner sbrunner deleted the mypy branch October 22, 2024 06:38
@sbrunner sbrunner added this to the 1.13.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

@carlio carlio Awaiting requested review from carlio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @Pierre-Sassoulas