Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better pre-commit order #689

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Better pre-commit order #689

merged 1 commit into from
Oct 22, 2024

Conversation

sbrunner
Copy link
Member

Description

Isort resolve some issues detected by flake8 => put is before

Prospector is slow => put it at last

By the way, what is the Prospector pre-commit for?, notes that:

  • He always returns 0
  • It's the master version who is running!

@sbrunner sbrunner marked this pull request as ready for review October 22, 2024 10:29
@carlio
Copy link
Member

carlio commented Oct 22, 2024

The prospector pre-commit hook is to test that it can run as a pre-commit hook, to validate the .pre-commit-hooks.yaml basically. It's not expected to lint, but just to run in case it breaks.

Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we could use Ruff and drop a lot of other hooks next

@sbrunner sbrunner merged commit 25b9c6c into master Oct 22, 2024
5 checks passed
@sbrunner sbrunner deleted the pre-commit-order branch October 22, 2024 13:59
@sbrunner sbrunner added this to the 1.13.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants