Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruff linter pre-commit hook #690

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Add Ruff linter pre-commit hook #690

merged 1 commit into from
Oct 22, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner marked this pull request as ready for review October 22, 2024 13:01
Pierre-Sassoulas
Pierre-Sassoulas requested changes Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should activate most of the check in particular UP and I in pyproject.toml (then remove isort and flake8)

@sbrunner sbrunner force-pushed the add-ruff branch 4 times, most recently from 57b6165 to 5141b4a Compare October 22, 2024 14:59
@sbrunner
Copy link
Member Author

Update, I also remove pyupgrade :-)

Pierre-Sassoulas
Pierre-Sassoulas reviewed Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! We can also use ruff-fmt instead of black

prospector/pathutils.py Show resolved Hide resolved
prospector/autodetect.py Outdated Show resolved Hide resolved
@sbrunner
Add Ruff linter pre-commit hook
db31a7f 
In place of isort, pyupgrade and flake8
Fix new checks
@sbrunner
Copy link
Member Author

Thanks for the review, fixed :-)

@Pierre-Sassoulas Pierre-Sassoulas merged commit a38e2ab into master Oct 22, 2024
5 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the add-ruff branch October 22, 2024 17:59
@sbrunner sbrunner added this to the 1.13.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pierre-Sassoulas Pierre-Sassoulas Pierre-Sassoulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @Pierre-Sassoulas