Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default options for mypy in the profiles #692

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

sbrunner
Copy link
Member

Description

I don't know how you manage the profiles, but those can be useful options for mypy,
what do you think?

@sbrunner sbrunner marked this pull request as ready for review October 22, 2024 18:43
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @carlio knows best

@carlio
Copy link
Member

carlio commented Jan 8, 2025

Sorry I didn't spot the review request!

@carlio carlio merged commit 3273f5e into master Jan 8, 2025
5 checks passed
@carlio carlio deleted the mypy-profile branch January 8, 2025 13:47
@carlio
Copy link
Member

carlio commented Jan 8, 2025

I don't know mypy that well so I'll trust that these are good default options :-)

The idea is that "less strict" profiles turn off or override the behaviour of the strictest ones, beyond that the attitude is that the default "medium" should not be so strict that it annoys users. I didn't want to put people off the idea of static analysis by drowning them in tiny problems immediately. This was a response to a particular colleague to responded to Java linting with @SupressWarning instead of fixing the warning...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants