Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blender when line is None #700

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Fix blender when line is None #700

merged 1 commit into from
Nov 14, 2024

Conversation

sbrunner
Copy link
Member

Description

Currently, we can obtain this exceptions:

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repocjulckrl/py_env-python3/bin/prospector", line 8, in <module>
    sys.exit(main())
             ^^^^^^
  File "/home/runner/.cache/pre-commit/repocjulckrl/py_env-python3/lib/python3.11/site-packages/prospector/run.py", line 200, in main
    prospector.execute()
  File "/home/runner/.cache/pre-commit/repocjulckrl/py_env-python3/lib/python3.11/site-packages/prospector/run.py", line 119, in execute
    messages = self.process_messages(found_files, messages)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/.cache/pre-commit/repocjulckrl/py_env-python3/lib/python3.11/site-packages/prospector/run.py", line 30, in process_messages
    messages = blender.blend(messages)
               ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/.cache/pre-commit/repocjulckrl/py_env-python3/lib/python3.11/site-packages/prospector/blender.py", line 91, in blend
    assert message.location.line is not None
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError

Then fix it

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sbrunner sbrunner marked this pull request as ready for review November 14, 2024 08:36
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Pierre-Sassoulas Pierre-Sassoulas added this to the 1.13.2 milestone Nov 14, 2024
@Pierre-Sassoulas
Copy link
Collaborator

Created 1.13.2 and 1.14.0 milestone, I don't know if you want to keep having those, but imo fixing bugs fast and releasing is what's important (changelog and properly labelled issue on github are nice to have).

@sbrunner sbrunner merged commit bd3a18c into master Nov 14, 2024
5 checks passed
@sbrunner sbrunner deleted the blender-line-none branch November 14, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants