Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter manual selected file #707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

sbrunner
Copy link
Member

Description

When we run, e.-g. prospector test.py currently the file test.py is filtered then the checks runs on all the files, it's relay not intuitive, and when we try to integrate it in another tool we get wrong results.

With the change, a specified file can't be filtered.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@sbrunner sbrunner force-pushed the specify-filtred-file branch 2 times, most recently from 27b84d6 to c3cd111 Compare December 27, 2024 08:57
@sbrunner sbrunner force-pushed the specify-filtred-file branch 5 times, most recently from 5ac40d3 to 9b607ed Compare January 9, 2025 08:40
Copy link
Collaborator

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great UX improvment imo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants