-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dired-*-line shortcuts #1
Comments
From: Peter Prevos ***@***.***>
Date: Sun, 25 Jun 2023 15:45:54 -0700
Hi Prot,
Hello Peter,
Interesting new package that is very useful for managing my
collections of photographs.
Yes, this is my use-case as well!
I use arrow keys to navigate Dired buffers. You remap the
`dired-*-line` functions to their `dired-preview-*` equivalents. But
somehow, it only remaps the `p` and `n` keys, not the arrow or space
keys that also map to the dried function.
I was surprised when I noticed this. I expected the remapping to apply
to all key bindings. I don't know why it only picked one, let alone why
it picked that one.
At any rate, we are discussing this on the mailing list, with Christian
Tietze suggesting an alternative approach that may work more reliably:
<https://lists.sr.ht/~protesilaos/general-issues/%3Cm1zg4noej2.fsf%40christiantietze.de%3E>.
Also, should PDFs be included as they are natively read by Emacs?
We can change the 'dired-preview-ignored-extensions-regexp' user option.
I don't have a strong opinion about it. We already have previewing with
a delay, plus there is the max size limit. Those help us avoid cases
where Emacs will take a long time to display the file.
All the best,
Prot
…--
Protesilaos Stavrou
https://protesilaos.com
|
I'll follow the mailing list. Issue closed. |
protesilaos
added a commit
that referenced
this issue
Jun 27, 2023
This is the same ideas as in commit ae93720, except more generalised. Instead of defining our own commands, we advise Dired to display a preview after one of its standard commands is called. This way we avoid the problem where the key remap mechanism does not actually remap all keys associated with a given command.[1][2] [1] Thanks to Peter Prevos for reporting this in issue 1 on the GitHub mirror: <#1>. [2] Thanks to Christian Tietze and Ed Hamilton for discussing this with me on the mailing list: <https://lists.sr.ht/~protesilaos/general-issues/%3Cm1zg4noej2.fsf%40christiantietze.de%3E>. Commit ae93720 by Christian Tietze is based on this discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Prot,
Interesting new package that is very useful for managing my collections of photographs.
I use arrow keys to navigate Dired buffers. You remap the
dired-*-line
functions to theirdired-preview-*
equivalents. But somehow, it only remaps thep
andn
keys, not the arrow or space keys that also map to the dried function.Also, should PDFs be included as they are natively read by Emacs?
P:)
The text was updated successfully, but these errors were encountered: