Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dired-*-line shortcuts #1

Closed
pprevos opened this issue Jun 25, 2023 · 2 comments
Closed

dired-*-line shortcuts #1

pprevos opened this issue Jun 25, 2023 · 2 comments

Comments

@pprevos
Copy link

pprevos commented Jun 25, 2023

Hi Prot,

Interesting new package that is very useful for managing my collections of photographs.

I use arrow keys to navigate Dired buffers. You remap the dired-*-line functions to their dired-preview-* equivalents. But somehow, it only remaps the p and n keys, not the arrow or space keys that also map to the dried function.

Also, should PDFs be included as they are natively read by Emacs?

P:)

@protesilaos
Copy link
Owner

protesilaos commented Jun 26, 2023 via email

@pprevos
Copy link
Author

pprevos commented Jun 26, 2023

I'll follow the mailing list. Issue closed.

@pprevos pprevos closed this as completed Jun 26, 2023
protesilaos added a commit that referenced this issue Jun 27, 2023
This is the same ideas as in commit ae93720, except more generalised.
Instead of defining our own commands, we advise Dired to display a
preview after one of its standard commands is called.  This way we
avoid the problem where the key remap mechanism does not actually
remap all keys associated with a given command.[1][2]

[1] Thanks to Peter Prevos for reporting this in issue 1 on the GitHub
    mirror: <#1>.

[2] Thanks to Christian Tietze and Ed Hamilton for discussing this
    with me on the mailing list:
    <https://lists.sr.ht/~protesilaos/general-issues/%3Cm1zg4noej2.fsf%40christiantietze.de%3E>.
    Commit ae93720 by Christian Tietze is based on this discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants