Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds placeholder preview buffers for ignored files for #14 #15

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Adds placeholder preview buffers for ignored files for #14 #15

merged 1 commit into from
Jul 17, 2024

Conversation

xenodium
Copy link

Previously discussed in #14, sending implementation PR.

Enable/disable via dired-preview-ignored-show-ignored-placeholders

Hopefully inline with existing package style/arch/spirit, but happy to tweak as needed.

Enable/disable via `dired-preview-ignored-show-ignored-placeholders`
@protesilaos protesilaos merged commit a402f9d into protesilaos:main Jul 17, 2024
@protesilaos
Copy link
Owner

Merged. Thank you!

Please let me know if you have assigned copyright to the Free Software Foundation. I am asking because this package is on GNU ELPA. The present patch should be fine though.

@xenodium
Copy link
Author

Please let me know if you have assigned copyright to the Free Software Foundation.

I don't, but I have been meaning to do it. Thanks for the reminder to go check it out.

protesilaos added a commit that referenced this pull request Jul 17, 2024
This was done in pull request 15:
<#15>.
protesilaos added a commit that referenced this pull request Jul 17, 2024
This was contributed by Álvaro Ramírez in pull request 15:
<#15>.
@protesilaos
Copy link
Owner

Okay, good to know! You will need it eventually for any more contributions, because the limit right now is for ~15 lines of non-trivial code.

@xenodium
Copy link
Author

SG! I've just emailed [email protected] requesting the assignment form.

@protesilaos
Copy link
Owner

protesilaos commented Jul 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants