Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit-tests for Transaction Fees #175

Merged
merged 15 commits into from
Jul 30, 2024
Merged

Unit-tests for Transaction Fees #175

merged 15 commits into from
Jul 30, 2024

Conversation

ejMina226
Copy link
Collaborator

@ejMina226 ejMina226 commented Jul 18, 2024 •
edited
Loading

New tests added:

  1. Transaction is rejected when sender can't cover the fee
  2. Check fee-payer receives fee when it is subtracted.
  3. Check app chain doesn't start when config is bad for transaction-fee.
  4. Add check that fee was computed properly, including helper function in TransactionFeeHook.ts

Also,

  1. Fixed typo: changing intializeFeeTree to initializeFeeTree
  2. Added in nvmrc file

@ejMina226 ejMina226 self-assigned this Jul 18, 2024
@ejMina226 ejMina226 changed the title New unit-test to check transaction is rejected when fee is too high Unit-tests for Transaction Fees Jul 18, 2024
@ejMina226 ejMina226 force-pushed the feature/fees-failure-test branch from 02d3d3a to a0fb448 Compare July 22, 2024 08:22
@ejMina226 ejMina226 changed the base branch from develop to feature/devops July 22, 2024 08:22
@ejMina226 ejMina226 marked this pull request as ready for review July 22, 2024 09:10
@ejMina226 ejMina226 requested review from maht0rz and rpanic and removed request for maht0rz July 22, 2024 14:14
@ejMina226 ejMina226 linked an issue Jul 23, 2024 that may be closed by this pull request
Improve test coverage for transaction fees #143
Closed
rpanic
rpanic reviewed Jul 24, 2024
View reviewed changes
packages/library/src/hooks/TransactionFeeHook.ts Outdated Show resolved Hide resolved
packages/sdk/test/fees-failures.test.ts Outdated Show resolved Hide resolved
packages/sdk/test/fees.test.ts Outdated Show resolved Hide resolved
@rpanic rpanic changed the base branch from feature/devops to develop July 30, 2024 19:53
@rpanic rpanic merged commit a776d4c into develop Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpanic rpanic rpanic approved these changes

@maht0rz maht0rz Awaiting requested review from maht0rz

Assignees

@ejMina226 ejMina226

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve test coverage for transaction fees
2 participants
@ejMina226 @rpanic