protobuf_generate passes options in the wrong order to protoc.

[MSK61]

protobuf/cmake/protobuf-generate.cmake

Line 141 in 47861d2

ARGS ${protobuf_generate_PROTOC_OPTIONS} --${protobuf_generate_LANGUAGE}_out ${_plugin_options}:${protobuf_generate_PROTOC_OUT_DIR} ${_plugin} ${_protobuf_include_path} ${_abs_file}

The plugin options ${_plugin_options} are misplaced between --${protobuf_generate_LANGUAGE}_out and ${protobuf_generate_PROTOC_OUT_DIR}. Even stranger, the options are nonsensically concatenated with a colon : to ${protobuf_generate_PROTOC_OUT_DIR}. I think the correct format for the arguments should be something like:

ARGS ${protobuf_generate_PROTOC_OPTIONS} --${protobuf_generate_LANGUAGE}_out ${protobuf_generate_PROTOC_OUT_DIR} ${_plugin_options} ${_plugin} ${_protobuf_include_path} ${_abs_file}

[acozzette]

The format may look strange but I think it's actually correct. A typical flag would look something like --cpp_out=option1,option2:path.

[MSK61]

The format may look strange but I think it's actually correct. A typical flag would look something like --cpp_out=option1,option2:path.

Does this agree with the --cpp_out option description here? It's stated that --cpp_out should only take the directory where the generated files are placed.

[acozzette]

You are right, it looks like this is not covered in the docs yet.