-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open up visibility for some compiler internals #10608
Merged
mkruskal-google
merged 13 commits into
protocolbuffers:main
from
mkruskal-google:grpc-visibility
Sep 26, 2022
Merged
Open up visibility for some compiler internals #10608
mkruskal-google
merged 13 commits into
protocolbuffers:main
from
mkruskal-google:grpc-visibility
Sep 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruskal-google
force-pushed
the
grpc-visibility
branch
from
September 16, 2022 21:20
b186f2e
to
b073d9b
Compare
haberman
previously requested changes
Sep 18, 2022
fowles
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable compromise to me
mkruskal-google
force-pushed
the
grpc-visibility
branch
from
September 19, 2022 17:31
67302d2
to
376b067
Compare
Good point, I'll add them thanks Josh! |
thomasvl
reviewed
Sep 19, 2022
thomasvl
reviewed
Sep 19, 2022
mkruskal-google
force-pushed
the
grpc-visibility
branch
from
September 19, 2022 23:24
376b067
to
6c37fcf
Compare
jskeet
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C# looks fine to me, with a few concerns to be checked.
mkruskal-google
force-pushed
the
grpc-visibility
branch
2 times, most recently
from
September 20, 2022 20:29
5d2fb17
to
15a00e8
Compare
thomasvl
approved these changes
Sep 22, 2022
…tails" This reverts commit b073d9b.
mkruskal-google
force-pushed
the
grpc-visibility
branch
from
September 23, 2022 15:23
6075f2f
to
ccc94c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9985 made all of our language-specific compiler code visibility-restricted in Bazel builds. While most of this code was intended to be internal, we never explicitly specified it. Specifically, gRPC (and likely other code generators) needs visibility into language-specific naming helpers.
This PR takes a middle-ground approach for our 22.x breaking release, only exposing what we think is reasonable for downstream codegen to reuse. Other alternatives open for discussion are: