Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto capitalize enums name in Ruby (#10454) #10708

Merged

Conversation

tisonkun
Copy link
Contributor

@tisonkun tisonkun commented Oct 4, 2022

This picks #10454 to branch-2.11. Refer to #1965.

cc @JasonLunn @mkruskal-google

@tisonkun
Copy link
Contributor Author

tisonkun commented Oct 5, 2022

ping @JasonLunn @mkruskal-google could you help with triggering the tests?

@mkruskal-google mkruskal-google added kokoro:run ruby jruby Issues unique to the JRuby interpreter labels Oct 5, 2022
@deannagarcia deannagarcia merged commit 1291e4a into protocolbuffers:main Oct 6, 2022
@deannagarcia
Copy link
Member

Thanks for upstreaming this! We don't have a planned date for the next release but should be within the next few weeks.

@tisonkun tisonkun deleted the pick-ruby-auto-capitalize branch October 6, 2022 22:45
@tisonkun
Copy link
Contributor Author

@deannagarcia @mkruskal-google emmm...IIRC I open this PR against 21.x but it's now merged into master (and I don't find the commit on master). What should I do now? @deannagarcia @mkruskal-google could you help with cherrypicking this patch?

@tisonkun tisonkun restored the pick-ruby-auto-capitalize branch October 11, 2022 17:29
@tisonkun
Copy link
Contributor Author

I create a new PR. This time I confirm that it's against 21.x:

image

If you'd like to proceed it, be careful before you click the merge button - I don't know what happened here :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jruby Issues unique to the JRuby interpreter ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants