BugFix for issue 13482 #13504
BugFix for issue 13482 #13504
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@jskeet , @tonydnewell here is the PR for the Bug |
| @@ -184,6 +184,15 @@ std::string UnderscoresToCamelCase(absl::string_view input, | |||
| } else if ('0' <= input[i] && input[i] <= '9') { | |||
| result += input[i]; | |||
| cap_next_letter = true; | |||
| // https://github.com/protocolbuffers/protobuf/issues/13482 | |||
| // Preserve underscores before numbers if the come right after a dot | |||
| } else if ( | |||
There was a problem hiding this comment.
Drive-by comment - I haven't analysed this fully - what would this do with "my.scope.__3"? I suspect we'd still end up with "my.scope.3", which presumably isn't intended.
There was a problem hiding this comment.
yes you are right, there is room for improvement, however my fix doesn't break anything and it still is an improvement. double underscore handling should be another PR as it makes things even more complicated. however most of the time when people only use one underscore it is an improvement
|
We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active, please add a comment. This PR is labeled |
github-actions
bot
added
the
inactive
|
We triage inactive PRs and issues in order to make it easier to find active work. If this PR should remain active or becomes active again, please reopen it. This PR was closed and archived because there has been no new activity in the 14 days since the |
#13482