Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring Bazel builds into compliance with upcoming breaking changes #15363

Closed
wants to merge 1 commit into from

Conversation

copybara-service[bot]
Copy link

Bring Bazel builds into compliance with upcoming breaking changes

This change makes our Bazel build compatible with all the migration-ready
--incompatible flags listed
here for Bazel 7.0,
with a couple exceptions listed below. This was mostly just a matter of
updating some of our dependencies to more recent versions.

The two flags we cannot support yet are these:

  • --incompatible_disallow_struct_provider_syntax: Bazel itself appears not
    to support this one yet, see
    here.
  • --incompatible_stop_exporting_language_modules: waiting on support in
    rules_jvm_external, see
    here.

I also deleted the broken //:protobuf_nowkt alias target, which was an
oversight on my part from a previous change.

This change makes our Bazel build compatible with all the migration-ready
`--incompatible` flags listed
[here](https://github.com/bazelbuild/bazel/releases/tag/7.0.0) for Bazel 7.0,
with a couple exceptions listed below. This was mostly just a matter of
updating some of our dependencies to more recent versions.

The two flags we cannot support yet are these:
 - `--incompatible_disallow_struct_provider_syntax`: Bazel itself appears not
   to support this one yet, see
   [here](bazelbuild/bazel#19467).
 - `--incompatible_stop_exporting_language_modules`: waiting on support in
   `rules_jvm_external`, see
   [here](bazel-contrib/rules_jvm_external#1027).

I also deleted the broken `//:protobuf_nowkt` alias target, which was an
oversight on my part from a previous change.

PiperOrigin-RevId: 597076542
Copy link

Auto-closing Copybara pull request

@github-actions github-actions bot closed this Jan 17, 2024
@github-actions github-actions bot deleted the test_597076542 branch January 17, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant