Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Python2-Python3 straddle. #164

Merged
merged 2 commits into from
Aug 22, 2015
Merged

Prepare for Python2-Python3 straddle. #164

merged 2 commits into from
Aug 22, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 13, 2015

  • Remove PY25 cruft.
  • Selectively apply cleanups from 'python-modernize':
    • New exception syntax.
    • Use 'six' to handle module renames.
    • Use 'six' to handle text / binary stuff.

This PR covers most of the work from #66 which falls inside python
(rather than the Python code generation stuff in 'src').

- Remove PY25 cruft.

- Selectively apply cleanups from 'python-modernize':

  - New exception syntax.
  - Use 'six' to handle module renames.
  - Use 'six' to handle text / binary stuff.

This PR covers most of the work from #66 which falls inside `python`
(rather than the Python code generation stuff in 'src').
@tamird
Copy link
Contributor

tamird commented May 15, 2015

@tseaver I think this can be merged now. Support for 2.5 and 2.6 is no longer needed. Do you want to take on the rebase?

@tamird tamird mentioned this pull request Aug 12, 2015
@haberman haberman merged commit fec1b8e into protocolbuffers:master Aug 22, 2015
bithium pushed a commit to bithium/protobuf that referenced this pull request Sep 4, 2023
Fixed oneof case accessor to cast to enum for C++.
yordis pushed a commit to yordis/protobuf that referenced this pull request Dec 8, 2024
Now that we only support OTP 22+. Also:

* Ensure proper cleanup on application shutdown by dropping all extensions stored in persistent_term. This also ensures clean restarts.
* Closes protocolbuffers#145 as an alternative approach to fix protocolbuffers#130.
* Rename internal Protobuf.Extensions functions to make it clearer they are private APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants