Cherry-pick "Revert workaround for std::mutex issues on github windows runners" and "Downgrade CMake to 3.29 to workaround Abseil issue." #17473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PiperOrigin-RevId: 648802955
zhangskz
requested review from
fowles,
bshaffer and
mkruskal-google
and removed request for
a team and
fowles
This was fixed in abseil/abseil-cpp@cd7f66c, but older versions of Abseil break in CMake 3.30, which github runners now use by default. PiperOrigin-RevId: 651854867
zhangskz
changed the title
mkruskal-google
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of 8d1efdd and da7b416