Support C11 atomics on compilers that don't define __GNUC__ if they declare an extension or C11 atomic support.
#19840
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_710873174
branch
from
26fba69 to
84eb907
Compare
… declare an extension or C11 atomic support. This fixes: * MSVC with `/std:c11 /experimental:c11atomics` on recent versions now emits atomics * Clang with `-std=c11 -fgnuc-version=0` now emits atomics * Clang and GCC 14 when built with `-std=c99 -pedantic-errors` will now compile, and not emit atomics PiperOrigin-RevId: 710873174
copybara-service
bot
force-pushed
the
test_710873174
branch
from
84eb907 to
d8f5bb6
Compare
copybara-service
bot
changed the title
__GNUC__, and if compiling without atomics, require users to say that's what they want with a define.__GNUC__ if they declare an extension or C11 atomic support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support C11 atomics on compilers that don't define
__GNUC__if they declare an extension or C11 atomic support.This fixes:
/std:c11 /experimental:c11atomicson recent versions now emits atomics-std=c11 -fgnuc-version=0now emits atomics-std=c99 -pedantic-errorswill now compile, and not emit atomics