ruby: make it possible to specify compiler for C extension #19863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously running `gem install google-protobuf --platform ruby` used the default C compiler specified by `mkmf`, which uses `RbConfig::MAKEFILE_CONFIG["CC"]` and `RbConfig::MAKEFILE_CONFIG["CXX"]`. This commit supports using `CC`, `CXX`, and `LD` from the environment: ``` export CC=my-custom-gcc export CXX=my-custom-g++ gem install google-protobuf --platform ruby ``` Most native gems, such as grpc and nokogiri, allow for this.
stanhu
force-pushed
the
sh-support-custom-gcc
branch
from
46e0dc3 to
33693f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously running
gem install google-protobuf --platform rubyused the default C compiler specified bymkmf, which usesRbConfig::MAKEFILE_CONFIG["CC"]andRbConfig::MAKEFILE_CONFIG["CXX"].This commit supports using
CC,CXX, andLDfrom the environment:Most native gems, such as grpc and nokogiri, allow for this.