Adding default shell env to allow non-default compilers #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am adding default shell environment, so that protobuf compilation makes use of set LD_LIBRARY_PATH and so on. In this way, also non-default gcc installations (e.g. not in /usr/lib) can be used to compile protobuf. This would fix the following issue: bazelbuild/bazel#2515
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
1 similar comment
|
Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure. |
|
Can one of the admins verify this patch? |
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
ok to test (this phrase will trigger the other CI runs) |
adamyi
added a commit
to adamyi/protobuf
that referenced
this pull request
Jul 29, 2020
We may need the shell environment (potentially augmented with `--action_env`) to invoke protoc on Windows. If protoc was built with mingw, it probably needs .dll files in non-default locations that must be in PATH. Previously with `--compiler=mingw-gcc`, `bazel build //:gen_well_known_protos_java` would fail on Windows. This CL fixes the issue. Also we have `default_shell_env` set to True for `ProtoCompile`, this makes the behavior consistent. See protocolbuffers#2933, and https://github.com/bazelbuild/rules_go/blob/585a27ad0ab5bdd185aa3bd5b0877a778d4777ad/proto/compiler.bzl#L130
acozzette
pushed a commit
that referenced
this pull request
Aug 20, 2020
We may need the shell environment (potentially augmented with `--action_env`) to invoke protoc on Windows. If protoc was built with mingw, it probably needs .dll files in non-default locations that must be in PATH. Previously with `--compiler=mingw-gcc`, `bazel build //:gen_well_known_protos_java` would fail on Windows. This CL fixes the issue. Also we have `default_shell_env` set to True for `ProtoCompile`, this makes the behavior consistent. See #2933, and https://github.com/bazelbuild/rules_go/blob/585a27ad0ab5bdd185aa3bd5b0877a778d4777ad/proto/compiler.bzl#L130
vesavlad
pushed a commit
to vesavlad/protobuf
that referenced
this pull request
Sep 22, 2020
We may need the shell environment (potentially augmented with `--action_env`) to invoke protoc on Windows. If protoc was built with mingw, it probably needs .dll files in non-default locations that must be in PATH. Previously with `--compiler=mingw-gcc`, `bazel build //:gen_well_known_protos_java` would fail on Windows. This CL fixes the issue. Also we have `default_shell_env` set to True for `ProtoCompile`, this makes the behavior consistent. See protocolbuffers#2933, and https://github.com/bazelbuild/rules_go/blob/585a27ad0ab5bdd185aa3bd5b0877a778d4777ad/proto/compiler.bzl#L130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding default shell environment, so that protobuf compilation makes use of set
LD_LIBRARY_PATH and so on.
In this way, also non-default gcc installations (e.g. not in /usr/lib) can be used to compile protobuf.
This would fix the following issue:
bazelbuild/bazel#2515