[do not merge] Remove the special-case code that suppresses pure-PHP properties. #9930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a chance this may fix some SEGVs seen on PHP 8.1 when OPCache is enabled: protocolbuffers#9446 (comment) However this also will increase memory usage of PHP protos, and will likely introduce CPU overhead also.
fowles
approved these changes
May 7, 2022
| zval arena; | ||
| const Descriptor* desc; | ||
| upb_Message *msg; | ||
| zend_object std; |
There was a problem hiding this comment.
please add a comment explaining that this must come last because PHP uses a tail allocation to do more fun stuff
|
Let me go ahead and close this since it sounds like the segfault problem has already been fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a chance this may fix some SEGVs seen on PHP 8.1 when
OPCache is enabled:
#9446 (comment)
However this also will increase memory usage of PHP protos, and
will likely introduce CPU overhead also. Therefore we probably don't
want to release the code in this state.
If this indeed fixes the SEGVs being seen, we should redesign the generated
code to no longer create properties unless pure-PHP is being used.
cc: @bshaffer