-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LatexIt v.0.6.8 incompatible with Thunderbird 78.2.2 #61
Comments
Thanks for the offers. Since I did the first conversions on a Linux machine, that is ok. We also have already proceeded to the next step in the conversion stage #62, so at the moment we are ok. But we could need help with the conversion itself! |
I am using the fork made by @jobisoft and it seems to work in in thunderbird 78.6.1. Many thanks! I really find this extension useful and it saved me as I could no longer use it in the new thunderbird |
I think it would be a good idea to point to the unfinished fork in the readme |
@marmistrz I assume the mailextension branch of this repository is meant (https://github.com/protz/LatexIt/tree/mailextension). Downloaded and followed procedure in Makefile. Runs fine on Windows and Thunderbird 78.7.1 (64-bit). Thank you very much for this neat feature, missed it in the last months. |
@fwillo, you are right, the If I remember correctly, the basic features are there, but the configuration is not working (but I might be wrong here, it's already 3½ months I did it and then I was "sidetracked" by my breadwinning job (and Christmas!). Anyone out there wanting to finish that job? |
A quick update … Since I last tried the
|
Update the used WindowListener API and the options page moves into the add-on manager! That solves the issue with option only accessible if menu bar is shown. |
Working on the pure html webextension options screen seems a good next step (you can make it inline in the add-on manager or as a tab). To not have to change too much at the same time, you can use the LegacyPrefs API to access the legacy pref branch to actually access the old prefs storage, so the remaining code does not need to be changed. Only later, when the add-on has been updated to work without the WindowListener API, you can switch to the webextension local storage. https://github.com/thundernest/addon-developer-support/tree/master/auxiliary-apis/LegacyPrefs |
The |
Thank you so much for updating the code so it is compatible with TB 78+ |
For everybody coming here looking for LatexIt! for TB 78 and who cannot wait for the official release on TB's add-on page, you can use this file for the moment (mind you, there might be still some rough edges!):
Please keep in mind, that this might break automatic updates and you have de-install the add-on and re-install it from the TB add-ons page as soon as the new version is made available! |
On Mac:
|
I tried this |
@tobiasBora: Go to the Or go to the What I always thought of the HTML editor as a WYSIWYG editor. Why does the theme changes the colours of the final HTML email sent?? |
@sphh Thanks for you answer, but I feel a bit stupid: here is what I get when I do that (I remember that on older version, we could directly modify the tex path, the default template...): Concerning the background, in KDE when I setup a dark theme, many things are dark, including the textarea... (however, the emails in my input box are rendered with a white background). |
You found a bug, the options page does not exist for me as well. I will investigate. |
@tobiasBora: What happens, if you select a colour for the text, let's say some shade of light grey? What will happen with the email sent out? Which colour does the email have? (I would find it weird, if it then has light grey on the default white background.) How could we predict the text colour after the email is sent? And if it is predicted as black, how would the equation be displayed in the editor having a dark background? Black (on black)? Personally, I find it a bit strange, that the theme fiddles with the colours in an editor, which can set the colours. (Just think of a drawing program – gimp – which changes the fore- and background colour when saving the file, if the user has not overwritten the defaults. That would be weird! But that is the impression I get from TB editor in dark theme mode!) Obviously it gets it right, when displaying the email, because it knows, it would mess up too many things by changing the background and foreground colour, maybe even render the email unreadable. Honestly, I would expect the same sensible approach, when writing the mails … |
@sphh, @tobiasBora I had the same problem when installing the latest commit of the mailextention branch on my windows machine. In the end I decided not to open a new issue because restarting TB after installing LatexIt, fixed the issue for me. I don't know if this will also work in your case but you can try. |
Hm, after a restart I am not able to reproduce this, even after removing and re-installing. Options are always there. Hm, strange. |
That's what I feared! Looks like however the colour of the equations is handled, there will be someone who will not be happy. Re your suggestion: The add-on looks for the colour of the element, where the equation is placed (most of the time that one of the surrounding text). It does it by DOM inspection, so it (currently) cannot detect, if that colour is set by the user or a theme. But if there is a way to figure out, where the colour of the text originates from (theme or custom setting), a fallback of black could be used, if the colour is set by the theme (and not the user). But I would need help, how this detection might work! I more believe, that this is bug in TB's message composer window itself, as you have proven with your little white/grey/black example! |
Ahah, that's for sure a tricky problem, I also have sometimes similar issues with equations in Firefox with dark background (but at least I can disable my dark background there). But since I can customize the template to put this Another solution I can imagine maybe is to put an optionnal check box (visible via the settings and via right clicking for instance) saying "use black color/use current text color" to allow the user to quickly move between both behavior. But I guess 99% of people will just want to write the equation always using the same color, so modifying the template will be enough for most of us. However, I think that a Warning could definitely be useful to limit the impact of such problems: this could be easier to implement I guess: if any formula uses a very light color, then display a warning like "Warning: we detected that you use a white font, and the pictures are therefore white. If you prefer to have darker pictures, please update the default template using $\textcolor{black}{....}$". Thanks for your work ;-) |
You know, what the best would be? TB reports not the current display colour, but the colour the element would have, when sending the email. We would then generate the equation in that colour. When displaying it in the composer window, there are two options: TB would display it as it is, if the user specified a colour of the surrounding element. If the element has the default foreground colour (managed by the theme), TB would adjust the foreground colour of the .png file to that one managed by the theme (which is technical possible). THAT would be the proper solution! The same technique could be used when displaying emails – and than you could read your emails in your beloved theme (even if is a HTML email). @jobisoft: Would that be feasible at all? |
IIRC we do not theme the message window exactly for this reason (checkout the standard black theme). What add-on is forcing the black background color? I think that should not do that OR that theme add-on must do the color adjustment. |
I'm back again about the theme color issues, sorry for the delay:
Also, to mitigate this problem, I wanted today to setup the |
@tobiasBora: Thanks for reporting it to TB. Re the replacement: What would you do, if you write your the equation in You can always write your equation as |
@sphh Concerning the replacement, I guess it could be possible to extract the separators into two other variables like Also, to make the equation readible for writer, is there a way to set the background color to, say, white instead of transparent? I tried to use |
Glad that It all depends, how |
we have the extension-finder now (tb91), where we can link from incompatible add-ons in the add-on manager to alternatives. so if someone wants to fork this add-on, give it a new id and load it onto ATN as a new add-on, we can make it visible to existing users. https://extension-finder.thunderbird.net/ it would of course be better, if the original maintainer would give access to a new maintainer instead. |
@jobisoft: A brilliant idea, that extension finder! Unfortunately it will not be, who fork this add-on, give it a new id and load it onto ATN, because my knowledge of JavaScrip, TB and ATN is limited, so is my ‘developing’ time, which is dedicated to my Python programs. I checked @protz contribution activity and it looks like his interests have moved to other places. A pity, because it would just require a release – all the hard work was done by other contributes, such as you, @jobisoft! I hope, that someone adapts this extension!! (Hey, are there any volunteers?) |
Hi, sorry to change the current topic, but coming back to the background/color/theming issue: Wouldn't giving an option to fix the background and font color (e.g. white background with black text) for the generated images be the best solution? The font color can be handled via \everymath, and I guess the background color could be made non-transparent by passing -bg 'rgb 1.0 1.0 1.0' to dvipng? I tried adding this flag to the path in the options, but then it can't find the executable anymore (it really wants only the path to dvipng without flags). |
@luhuhis: This would be a separate issue. I would not have a problem to grow an extra option to specify the background colour, but I got the impression, that @protz does not like more options. But since he became quiet, a fork could deal with it. Do you want to volunteer? Anyway, if you read
Your solution would be to get that |
@sphh: It seems that @MaxKoll has already made a fork that he is now maintaining: see fork. There is even an unofficial release for it! I just tested this release on my Windows10 machine and it works quite well. I don't know if he is willing to become the new maintainer for this extension, or if @protz is willing to give access to a new maintainer? |
I would like to point out, that there is https://fred-wang.github.io/TeXZilla/ which is a pure JS lib to render Latex Code. The latest version of Markdown Here is using it to render Latex. That add-on is almost pure WebExt (using a notification Experiment, which is not a critical component) and does not need a local Latex install. This might be a good replacement for Latex-IT or a good source for inspiration on how to move Latex-IT forward. |
I had no contact. From my own experience, however, I can fully understand, that a job can take up most of the available time and the remaining time is spent with family/friends - not leaving any time for this. Could you give Markdown Here a try, if it would be a possible replacement? |
I have to said that since the upgrade of thunderbird to 91.5.0, the LatexIt was not working for me. |
OK, now I see that the option is now deprecated: Math rendering using Google Chart API (deprecated) |
I am certainly aware of this. I have been in the same situation, so I can understand it perfectly. But it is just such a pity, that after all the hard work done by you, it was never finally published on TB's add-on page. This was the last step missing and as I understand it only @protz could do it. Such a waste … |
The work I have done helped to create a concept which helped lots of other add-ons as well, so it is not wasted. I really like how Markdown Here is doing it, as it is much easer to setup and it is already future proof and will not break with newer TB releases. If you could test it and agree that it is a suitable alternative, I would add it to our alternatives database and users would get an in-application hint where they could find the replacement. |
I gave Markdown here another try (previously I immediately discarded it, after I noticed that it sends my data to Google). It is a mixed blessing: You start the message in HTML mode with all the formatting available in the toolbar, but whenever you press the After reading https://gitlab.com/jfx2006/markdown-here-revival/-/issues/4 I learned, that it is possible to just convert the parts selected, which is ok for one or two formulae, but gets tedious if you happen to have more of them … |
FYI, if Thunderbird 102 refuses to send emails it might be caused by this add-on. |
I confirm this issue. Today my thunderbird updated to 102 version and I can no longer send e-mails. Unfortunately, I had to disable the add-on. |
Thank you for your work! |
I have the same problem. LaTeX It! checks, if there is still the debug message shown. This might be the cause of the problem. But this is just a guess … |
Thanks for your great contribution with LatexIt -- I use it frequently.
What's the expectation for Tbird 78.2.2 compatibility?
Thanks. -Mark
The text was updated successfully, but these errors were encountered: