remove ADR-038 plugin system due to AppHash error #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of ADR-038 - State Listening plugin system results in an
AppHash
mismatch error when implemented in the Provenance blockchain. This PR removes the implementation from the forked release branch as it is not usable. In addition, the plugin system uses Kafka as one of its services which currently does not have support for Apple M1 chips and requires some manual installation processes that make it difficult for Provenance clients to build and run the binary even when they're not using the plugin system. The ADR-038 implementation will eventually come from upstream so removing it will also keep therelease-pio/v0.45.x
branch clean.NOTE: There is a PR in place to implement a lighter version directly into the Provenance API that borrows from ADR-038.
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change