Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ADR-038 plugin system due to AppHash error #215

Merged

Conversation

egaxhaj
Copy link

@egaxhaj egaxhaj commented Jul 29, 2022

Description

The current implementation of ADR-038 - State Listening plugin system results in an AppHash mismatch error when implemented in the Provenance blockchain. This PR removes the implementation from the forked release branch as it is not usable. In addition, the plugin system uses Kafka as one of its services which currently does not have support for Apple M1 chips and requires some manual installation processes that make it difficult for Provenance clients to build and run the binary even when they're not using the plugin system. The ADR-038 implementation will eventually come from upstream so removing it will also keep the release-pio/v0.45.x branch clean.

NOTE: There is a PR in place to implement a lighter version directly into the Provenance API that borrows from ADR-038.

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@egaxhaj egaxhaj changed the title remove adr-038 plugin system, it will come from upstream removed adr-038 plugin system Jul 29, 2022
@egaxhaj egaxhaj changed the title removed adr-038 plugin system remove ADR-038 plugin system Jul 29, 2022
@egaxhaj egaxhaj changed the title remove ADR-038 plugin system remove ADR-038 plugin system due to AppHash error Jul 29, 2022
@@ -9,7 +9,6 @@ require (
github.com/btcsuite/btcd v0.22.0-beta
github.com/coinbase/rosetta-sdk-go v0.7.0
github.com/confio/ics23/go v0.6.6
github.com/confluentinc/confluent-kafka-go v1.8.2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAAAAASSSSSS!!!!!! 💯 💯

Copy link

@SpicyLemon SpicyLemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpicyLemon SpicyLemon merged commit 0912dba into release-pio/v0.45.x Jul 29, 2022
@egaxhaj egaxhaj deleted the prov/egaxhaj/remove-adr-038-plugin-system branch July 29, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants