-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/confluentinc/confluent-kafka-go from 1.8.2 to 1.9.0 #883
Bump github.com/confluentinc/confluent-kafka-go from 1.8.2 to 1.9.0 #883
Conversation
Bumps [github.com/confluentinc/confluent-kafka-go](https://github.com/confluentinc/confluent-kafka-go) from 1.8.2 to 1.9.0. - [Release notes](https://github.com/confluentinc/confluent-kafka-go/releases) - [Changelog](https://github.com/confluentinc/confluent-kafka-go/blob/master/CHANGELOG.md) - [Commits](confluentinc/confluent-kafka-go@v1.8.2...v1.9.0) --- updated-dependencies: - dependency-name: github.com/confluentinc/confluent-kafka-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #883 +/- ##
==========================================
+ Coverage 56.20% 56.26% +0.05%
==========================================
Files 181 181
Lines 22254 22234 -20
==========================================
+ Hits 12507 12509 +2
+ Misses 8790 8768 -22
Partials 957 957
|
Note: Building on an M1 mac will require an upgraded > make build
--> Ensure dependencies have not been modified
all modules verified
mkdir -p /Users/danielwedul/git/provenance/build
CGO_LDFLAGS="-Wl,-rpath,@loader_path/." CGO_CFLAGS="" /opt/homebrew/bin/go build -o /Users/danielwedul/git/provenance/build/ -mod=readonly -tags "netgo dynamic gcc cleveldb badgerdb ledger" -ldflags '-w -s -X github.com/cosmos/cosmos-sdk/version.Name=Provenance -X github.com/cosmos/cosmos-sdk/version.AppName=provenanced -X github.com/cosmos/cosmos-sdk/version.Version=dependabot-go_modules-jackfan.us.kg-confluentinc-confluent-kafka-go-1.9.0-e9584ee8 -X github.com/cosmos/cosmos-sdk/version.Commit=e9584ee8 -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,dynamic,gcc,cleveldb,badgerdb,ledger" -X github.com/tendermint/tendermint/version.TMCoreSemVer=v0.34.19' -trimpath ./cmd/provenanced
<snip>
# github.com/confluentinc/confluent-kafka-go/kafka
../../go/pkg/mod/github.com/confluentinc/[email protected]/kafka/00version.go:42:2: error: "confluent-kafka-go requires librdkafka v1.9.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`"
#error "confluent-kafka-go requires librdkafka v1.9.0 or later. Install the latest version of librdkafka from Homebrew by running `brew install librdkafka` or `brew upgrade librdkafka`"
^
1 error generated.
make: *** [build] Error 2 |
…c/confluent-kafka-go-1.9.0
Note: We can wait bumping up to |
When I tested this locally (M1 mac), I had to $ cd /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/
$ curl https://raw.githubusercontent.com/Homebrew/homebrew-core/42003356f2bf2d9057f8536e6130805be60d7b7f/Formula/librdkafka.rb > librdkafka.rb
$ brew unlink librdkafka
$ brew install librdkafka
$ git reset --hard To figure out that url, I pointed my browser to |
A newer version of github.com/confluentinc/confluent-kafka-go exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
I'm going to close this as something we won't do since we're hopefully removing the kafka dependency in the near future anyway (we've removed it from our Cosmos-SDK fork at least). |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps github.com/confluentinc/confluent-kafka-go from 1.8.2 to 1.9.0.
Release notes
Sourced from github.com/confluentinc/confluent-kafka-go's releases.
Changelog
Sourced from github.com/confluentinc/confluent-kafka-go's changelog.
Commits
c6c4e03
version 1.9.0 in CHANGELOG, go.mod, README (#803)d38dbd4
min version check updated to 1.9.0 (#802)b89b9e4
Improvements to Go client examples (#801)9c586e3
fixes #723 (#787)e1fd1c9
KIP-140: ACL operations (#796) (#799)e34bc9a
Update the consumer close function with the latest rd_kafka_consumer_close_qu...c1ad021
Merge pull request #798 from confluentinc/import_v1.9.0e50cdaf
chore: update repo semaphore projectf195ac6
Documentation and error code update for librdkafka v1.9.0a3f1fcd
librdkafka static bundle v1.9.0Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)