feat(findings): add /findings/metadata to retrieve dynamic filters information #6503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6503 +/- ##
==========================================
- Coverage 93.78% 93.67% -0.12%
==========================================
Files 65 65
Lines 6244 6304 +60
==========================================
+ Hits 5856 5905 +49
- Misses 388 399 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
vicferpoy
deleted the
PRWLR-5936-refactor-findings-dynamic-filter-endpoints-to-include-tags-and-resource-types
branch
|
We need to backport this PR to v5.1 since this feature was backported there and requires the code present here #6524 |
prowler-bot
added
the
was-backported
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
jfagoagas
added
backport-to-v5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to improve the UI dynamic filters and add more information, we have developed a new endpoint
GET /findings/metadataand deprecatedGET /findings/findings_services_regions.The response of this new endpoint includes resource tags and types:
{ "data": { "type": "findings-metadata", "id": null, "attributes": { "services": [ "accessanalyzer", "bedrock", "cloudformation", "cloudtrail", "cloudwatch", "config", "drs", "ec2", "emr", "eventbridge", "glue", "guardduty", "iam", "inspector2", "lightsail", "macie", "organizations", "resourceexplorer2", "s3", "securityhub", "support", "vpc" ], "regions": [ "ap-northeast-1", "ap-northeast-2", "ap-northeast-3", "ap-south-1", "ap-southeast-1", "ap-southeast-2", "ca-central-1", "eu-central-1", "eu-north-1", "eu-south-2", "eu-west-1", "eu-west-2", "eu-west-3", "sa-east-1", "us-east-1", "us-east-2", "us-west-1", "us-west-2" ], "resource_types": [ "AwsAccount", "AwsCloudFormationStack", "AwsCloudTrailTrail", "AwsEc2SecurityGroup", "AwsEc2Vpc", "AwsEc2VpcEndpointService", "AwsEventSchemasRegistry", "AwsEventsEventbus", "AwsGlueDataCatalog", "AwsGuardDutyDetector", "AwsIamPolicy", "AwsIamRole", "AwsIamUser", "AwsS3AccountPublicAccessBlock", "AwsS3Bucket", "Other" ], "tags": { "CloudFormation": "true", "Name": "ProwlerProSaaSScanRole", "Service": "https://prowler.pro", "Support": "[email protected]", "Version": "1.0.1" } } } }License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.