Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(services): delete all comment headers #6585

Merged

Conversation

HugoPBrito
Copy link
Member

Context

It was discussed previously that those header comments needed to be removed, and they have been gradually eliminated. However, some still remain. The task now is to remove the remaining ones.

Description

All header comments have been deleted and the dev guide has been updated reflecting this change.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners January 17, 2025 12:09
@github-actions github-actions bot added documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider labels Jan 17, 2025
Copy link
Contributor

You can check the documentation for this PR here -> Prowler Documentation

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (54d87fa) to head (c421db4).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6585      +/-   ##
==========================================
- Coverage   93.70%   89.44%   -4.27%     
==========================================
  Files          66     1182    +1116     
  Lines        6340    33785   +27445     
==========================================
+ Hits         5941    30219   +24278     
- Misses        399     3566    +3167     
Flag Coverage Δ
api ?
prowler 89.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 89.44% <ø> (∅)
api ∅ <ø> (∅)

@MrCloudSec MrCloudSec changed the title feat(services): delete all comment headers chore(services): delete all comment headers Jan 17, 2025
@MrCloudSec MrCloudSec merged commit 9a332dc into master Jan 17, 2025
11 of 12 checks passed
@MrCloudSec MrCloudSec deleted the PRWLR-5970-delete-all-header-comments-from-services branch January 17, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation provider/aws Issues/PRs related with the AWS provider provider/azure Issues/PRs related with the Azure provider provider/gcp Issues/PRs related with the Google Cloud Platform provider provider/kubernetes Issues/PRs related with the Kubernetes provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants