Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: microsoft365 mutelist #6724

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

HugoPBrito
Copy link
Member

Context

After modifying the Check Report to include resource metadata in M365, we unintentionally broke the mutelist. This needs to be fixed.

Description

Check Report for microsoft365 has been corrected to include the field tenant_id that was breaking the mutelist.

Checklist

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HugoPBrito HugoPBrito requested review from a team as code owners January 29, 2025 09:37
Copy link
Member

@pedrooot pedrooot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks for this 🔝

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (545c2dc) to head (4ec3b3b).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6724      +/-   ##
==========================================
- Coverage   93.70%   88.73%   -4.97%     
==========================================
  Files          67     1195    +1128     
  Lines        6351    34473   +28122     
==========================================
+ Hits         5951    30590   +24639     
- Misses        400     3883    +3483     
Flag Coverage Δ
api ?
prowler 88.73% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
prowler 88.73% <100.00%> (∅)
api ∅ <ø> (∅)

@puchy22 puchy22 merged commit 1256c04 into master Jan 31, 2025
10 of 11 checks passed
@puchy22 puchy22 deleted the PRWLR-6125-fix-mutelist-in-m-365-provider branch January 31, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants